Files
Archivum/backend/internal/auth/oidc.go
Bjorn Blomberg cd588197b9
All checks were successful
build-and-push / build (push) Successful in 15m15s
feat: Authentik OIDC SSO, allow/deny RBAC, admin console & Gitea CI
Authentication & RBAC
- Add confidential OIDC client (Authentik) with /auth/oidc/login +
  /auth/oidc/callback: discovery, code exchange, id_token verify (go-oidc),
  groups claim → role (Archivum-admin → admin, else user). Sessions carry groups.
- Rework ACL into an allow/deny model (new `effect` column + migration).
  db.EffectiveAccess resolves user + all groups over the path and its ancestors:
  default deny, explicit deny always beats allow.
- Enforce ACL for ALL non-admin users (not just guest) across list/read/save/
  delete/move/create/history/diff/images/upload. Admins bypass.
- Seed built-in Archivum-admin / Archivum-reader groups; login allow-list on
  users & groups; public (guest) user access is ACL-configurable.

Admin API & UI
- New GraphQL ops: oidcConfig/updateOidcConfig, group CRUD, membership,
  setUserRole/setUserLogin/setGroupLogin, userGroups, loginOptions.
- Rebuilt AdminView: SSO config, user/group management + membership, login
  toggles, and an allow/deny access-control matrix per path.
- LoginView: "Sign in with Authentik" + public-user option; OIDC callback route.

Rendering/editor
- Fix bug where inline marks (bold/italic/code/strike/link) were dropped on
  TipTap→AsciiDoc save. Add RENDERING_IMPROVEMENTS.md with proposals.

CI / build
- .gitea/workflows/build.yaml: build on the Pi5 runner, push
  localhost:5000/archivum:{latest,<sha>}. Add .dockerignore; bump Go image to 1.25.
- Docs: ARCHITECTURE.md, README.md, docs/AUTHENTIK_SETUP.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-05 21:58:50 +02:00

232 lines
5.4 KiB
Go

package auth
import (
"context"
"crypto/rand"
"encoding/hex"
"errors"
"strings"
"sync"
"time"
"github.com/brasse-b/archivum/internal/config"
"github.com/coreos/go-oidc/v3/oidc"
"golang.org/x/oauth2"
)
// OIDCUser is the identity extracted from a verified id_token / userinfo.
type OIDCUser struct {
Username string
Email string
Groups []string
}
var ErrOIDCNotConfigured = errors.New("OIDC not configured")
type oidcState struct {
expiresAt time.Time
}
// OIDCProvider wraps an OpenID Connect provider and OAuth2 client and manages
// the short-lived CSRF state values used during the auth-code flow. It can be
// reconfigured at runtime (after an admin changes the OIDC settings).
type OIDCProvider struct {
mu sync.Mutex
cfg config.OIDCConfig
redirect string
oauth *oauth2.Config
provider *oidc.Provider
verifier *oidc.IDTokenVerifier
ready bool
states map[string]oidcState
}
func NewOIDCProvider() *OIDCProvider {
return &OIDCProvider{states: make(map[string]oidcState)}
}
// Configure (re)initialises the provider from config. It performs OIDC
// discovery against the issuer, which requires network access to the IdP.
// Returns an error if discovery fails; the provider is then left disabled.
func (p *OIDCProvider) Configure(ctx context.Context, cfg config.OIDCConfig, redirectURL string) error {
cfg.Normalize()
p.mu.Lock()
p.cfg = cfg
p.redirect = redirectURL
p.ready = false
p.provider = nil
p.verifier = nil
p.oauth = nil
p.mu.Unlock()
if !cfg.Enabled || cfg.Issuer == "" || cfg.ClientID == "" || redirectURL == "" {
return nil
}
provider, err := oidc.NewProvider(ctx, strings.TrimRight(cfg.Issuer, "/"))
if err != nil {
return err
}
oauthCfg := &oauth2.Config{
ClientID: cfg.ClientID,
ClientSecret: cfg.ClientSecret,
Endpoint: provider.Endpoint(),
RedirectURL: redirectURL,
Scopes: []string{oidc.ScopeOpenID, "profile", "email", cfg.GroupsClaim},
}
verifier := provider.Verifier(&oidc.Config{ClientID: cfg.ClientID})
p.mu.Lock()
p.provider = provider
p.oauth = oauthCfg
p.verifier = verifier
p.ready = true
p.mu.Unlock()
return nil
}
// Enabled reports whether the provider is configured and ready.
func (p *OIDCProvider) Enabled() bool {
p.mu.Lock()
defer p.mu.Unlock()
return p.ready
}
// AuthURL creates a fresh state value and returns the authorization URL to
// redirect the browser to.
func (p *OIDCProvider) AuthURL() (string, error) {
p.mu.Lock()
defer p.mu.Unlock()
if !p.ready {
return "", ErrOIDCNotConfigured
}
state := randToken()
p.states[state] = oidcState{expiresAt: time.Now().Add(10 * time.Minute)}
p.gcStatesLocked()
return p.oauth.AuthCodeURL(state), nil
}
// Exchange validates the state, swaps the code for tokens, verifies the
// id_token and returns the resulting identity (with groups). If the id_token
// carries no groups claim it falls back to the userinfo endpoint.
func (p *OIDCProvider) Exchange(ctx context.Context, state, code string) (*OIDCUser, error) {
p.mu.Lock()
if !p.ready {
p.mu.Unlock()
return nil, ErrOIDCNotConfigured
}
st, ok := p.states[state]
if ok {
delete(p.states, state)
}
oauthCfg := p.oauth
verifier := p.verifier
provider := p.provider
cfg := p.cfg
p.mu.Unlock()
if !ok || time.Now().After(st.expiresAt) {
return nil, errors.New("invalid or expired state")
}
tok, err := oauthCfg.Exchange(ctx, code)
if err != nil {
return nil, err
}
rawID, ok := tok.Extra("id_token").(string)
if !ok {
return nil, errors.New("no id_token in token response")
}
idTok, err := verifier.Verify(ctx, rawID)
if err != nil {
return nil, err
}
var claims map[string]interface{}
if err := idTok.Claims(&claims); err != nil {
return nil, err
}
user := &OIDCUser{
Username: claimString(claims, cfg.UsernameClaim),
Email: claimString(claims, "email"),
Groups: claimStrings(claims, cfg.GroupsClaim),
}
// Some providers only expose groups via userinfo — fall back to it.
if len(user.Groups) == 0 && provider != nil {
if ui, err := provider.UserInfo(ctx, oauth2.StaticTokenSource(tok)); err == nil {
var uiClaims map[string]interface{}
if err := ui.Claims(&uiClaims); err == nil {
user.Groups = claimStrings(uiClaims, cfg.GroupsClaim)
if user.Username == "" {
user.Username = claimString(uiClaims, cfg.UsernameClaim)
}
if user.Email == "" {
user.Email = claimString(uiClaims, "email")
}
}
}
}
if user.Username == "" {
user.Username = user.Email
}
if user.Username == "" {
user.Username = idTok.Subject
}
if user.Username == "" {
return nil, errors.New("could not determine username from OIDC claims")
}
return user, nil
}
func (p *OIDCProvider) gcStatesLocked() {
now := time.Now()
for k, v := range p.states {
if now.After(v.expiresAt) {
delete(p.states, k)
}
}
}
func claimString(claims map[string]interface{}, key string) string {
if v, ok := claims[key].(string); ok {
return v
}
return ""
}
func claimStrings(claims map[string]interface{}, key string) []string {
raw, ok := claims[key]
if !ok {
return nil
}
switch v := raw.(type) {
case []interface{}:
out := make([]string, 0, len(v))
for _, item := range v {
if s, ok := item.(string); ok && s != "" {
out = append(out, s)
}
}
return out
case []string:
return v
case string:
if v == "" {
return nil
}
return []string{v}
}
return nil
}
func randToken() string {
b := make([]byte, 32)
_, _ = rand.Read(b)
return hex.EncodeToString(b)
}